Update r-tmae to 1.0.2 #31069
Update r-tmae to 1.0.2 #31069
Conversation
Also remove from run deps since it's implicitly added by openssl's run_exports.
HDF5Array.so is also directly linked to OpenSSL: > readelf -d lib/R/library/HDF5Array/libs/HDF5Array.so | grep libcrypto > 0x0000000000000001 (NEEDED) Shared library: [libcrypto.so.1.1]
| @@ -28,6 +28,7 @@ requirements: | |||
| - bioconductor-DESeq2 | |||
| - bioconductor-IRanges | |||
| - bioconductor-GenomicRanges | |||
| - bioconductor-hdf5array | |||
There was a problem hiding this comment.
Why only in host but not run? bioconductor-hdf5array does [edit]not[/edit] define any run_exports and as such won't be added to run implicitly.
There was a problem hiding this comment.
I think its a bug, and was a proof of concept. The DAG is not properly build if you do not specify the direct dependencies.
https://app.circleci.com/pipelines/github/bioconda/bioconda-recipes/54750/workflows/ddf69ab9-9bf4-4a6c-adfe-2e09fc7f8f75/jobs/173070?invite=true#step-106-18
Now it build in the right order.
I will create a issue.
There was a problem hiding this comment.
Did you mean to write indirect dependency? If it's a direct dependency, then it has to be listed (i.e., only in that case the way the DAG can and should be created that way).
There was a problem hiding this comment.
(if it is an indirect dependency, we should split this PR in two and have the *hdf* packages be built beforehand.)
There was a problem hiding this comment.
So hdf5* is an indirect dependency of t-mae. I assume that this still gets picked up by the DAG. No? Then we have to split it. See #31185
There was a problem hiding this comment.
I'm not sure why the DAG wasn't created as expected. Possibly because it didn't look at dependency chains that includes non-to-be-built packages? I can't remember how the DAG is built, TBH.
Yes, please open another PR. (I'll be AFK for the rest of the day, but can approve/merge tomorrow if no one else beats me to it.)
There was a problem hiding this comment.
And with that other PR then merged you can remove the indirect dependency from the requirements list again (because we actually don't want to directly depend on indirect deps.)
There was a problem hiding this comment.
Yes, I will do this. Thanks for the help!
We moved the main git developer repo to https://github.com/gagneurlab/tMAE.
In addition, this update makes #30957 obsolete.
closes gh-31072, gh-30957