Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install v1.0.0 deepmicrobes #35862

Closed
wants to merge 12 commits into from

Conversation

jayramr
Copy link
Contributor

@jayramr jayramr commented Jul 15, 2022

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@jayramr
Copy link
Contributor Author

jayramr commented Jul 16, 2022

help needed
"ModuleNotFoundError: No module named 'models'" How to specify this module name?

@jayramr
Copy link
Contributor Author

jayramr commented Jul 16, 2022

@BiocondaBot help needed

@daler
Copy link
Member

daler commented Jul 19, 2022

Tons of errors in the log about clobbering paths. E.g.,

ClobberWarning: This transaction has incompatible packages due to a shared path.
packages: defaults/linux-64::tensorflow-base-1.9.0-gpu_py36h6ecc378_0, conda-forge/linux-64::tensorflow-1.9.0-py36_0
path: 'lib/python3.6/site-packages/tensorflow/include/Eigen/src/Eigenvalues/ComplexSchur.h'

So it looks like the defaults channel tensorflow-base is already in the conda-forge package tensorflow. You probably only need the latter.

@jayramr
Copy link
Contributor Author

jayramr commented Jul 20, 2022

You probably only need the latter.

Thanks for your update.
Please advise how to pass this ? Do i need to specify a different version.
I checked on deeplc package yaml, they are using tensorflow , not sure how this succeeds

@daler
Copy link
Member

daler commented Jul 21, 2022

@jayramr looking at the upstream repo, it is not installed as typical python package despite being split into modules. It will not be straightforward to package.

One possible way of getting this working is to to copy over the relevant directories from the source repo into the conda package. However these should not go directly into the bin dir to avoid cluttering it. You will likely need to copy them into share and symlink to that location from bin. You might find some hints in e.g. https://github.com/bioconda/bioconda-recipes/blob/master/recipes/peptide-shaker/build.sh.

I'd recommend testing extensively locally before pushing back here.

@jayramr jayramr force-pushed the install_v1.0.0_deepmicrobes branch from feaec40 to ab8a706 Compare July 21, 2022 10:46
@dpryan79
Copy link
Contributor

The issue is that this (deepmicrobes) isn't written like a python package. It's just a set of scripts and you need to execute it from within the source so the models directory is in the import path. Can you ask the authors to restructure this a bit into a normal package so something like pip install will work with it? They basically just need a setup.py.

@jayramr
Copy link
Contributor Author

jayramr commented Sep 15, 2022

The issue is that this (deepmicrobes) isn't written like a python package. It's just a set of scripts and you need to execute it from within the source so the models directory is in the import path. Can you ask the authors to restructure this a bit into a normal package so something like pip install will work with it? They basically just need a setup.py.
Thanks @dpryan79 i will request them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants