Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin tabix version in snippy #46458

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

rpetit3
Copy link
Member

@rpetit3 rpetit3 commented Mar 15, 2024

related to #46114

the pinned vcflib version does not owrk with newer versions of tabixxp


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@rpetit3 rpetit3 requested a review from pvanheus March 15, 2024 04:51
@rpetit3
Copy link
Member Author

rpetit3 commented Mar 15, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Azure

Package(s) built on Azure are ready for inspection:

Arch Package Zip File
noarch snippy-4.6.0-hdfd78af_4.tar.bz2 LinuxArtifacts

You may also use conda to install these after downloading and extracting the appropriate zip file. From the LinuxArtifacts or OSXArtifacts directories:

conda install -c ./packages <package name>

Docker image(s) built (images for Azure are in the LinuxArtifacts zip file above):

Package Tag Install with docker
snippy 4.6.0--hdfd78af_4
showgzip -dc LinuxArtifacts/images/snippy:4.6.0--hdfd78af_4.tar.gz | docker load

@rpetit3
Copy link
Member Author

rpetit3 commented Mar 15, 2024

Testing on my end

Current build hdfd78af_3 isntalled tabixpp 1.1.2 hd68fcf3_1

mamba create -n snippy-test -c conda-forge -c bioconda snippy
mamba activate snippy
vcfuniq
vcfuniq: error while loading shared libraries: libtabixpp.so.0: cannot open shared object file: No such file or directory

With updated recipe and artifacts

mamba create -n snippy-artifacts -c conda-forge -c bioconda \
    perl \
    'perl-bioperl>=1.7.2' \
    'bwa>=0.7.17' \
    'samtools>=1.10' \
    'bcftools>=1.10' \
    'bedtools>=2.28.0' \
    'parallel>=20170422' \
    'freebayes>=1.3.1' \
    'vcflib>=1.0.0_rc3,<=1.0.2' \
    'tabixpp=1.1.0' \
    'snpeff>=4.3,<=5.0' \
    'vt>=0.5772' \
    'snp-sites>=2.4' \
    'any2fasta>=0.4' \
    'samclip>=0.4' \
    'seqtk>=1.3' \
    'minimap2>=2.17' \
    'openjdk>=11'
mamba activate snippy-artifacts
wget -O LinuxArtifacts.zip https://artprodsu6weu.artifacts.visualstudio.com/A27bcc0f9-b22c-4418-83d8-514809b37fb2/25074ded-3133-43ca-af80-895ab87b53cb/_apis/artifact/cGlwZWxpbmVhcnRpZmFjdDovL2Jpb2NvbmRhL3Byb2plY3RJZC8yNTA3NGRlZC0zMTMzLTQzY2EtYWY4MC04OTVhYjg3YjUzY2IvYnVpbGRJZC81MzQzNi9hcnRpZmFjdE5hbWUvTGludXhBcnRpZmFjdHM1/content?format=zip
unzip LinuxArtifacts.zip
conda install LinuxArtifacts/packages/noarch/snippy-4.6.0-hdfd78af_4.tar.bz2
vcfuniq --help


Usage: vcfuniq <vcf file>

List unique genotypes.  Like GNU uniq, but for VCF records.  Remove
records which have the same positon, ref, and alt as the previous
record.

Type: filter

I think we are good now

@rpetit3 rpetit3 merged commit 4dbae67 into bioconda:master Mar 15, 2024
6 checks passed
@rpetit3 rpetit3 deleted the rp3-update-snippy branch March 15, 2024 16:46
martin-g pushed a commit to martin-g/bioconda-recipes that referenced this pull request Mar 18, 2024
* pin tabix version in snippy

* fix tabix typo
Tim15-tech pushed a commit to Tim15-tech/bioconda-recipes that referenced this pull request Mar 18, 2024
* pin tabix version in snippy

* fix tabix typo
Tim15-tech pushed a commit to Tim15-tech/bioconda-recipes that referenced this pull request Apr 3, 2024
* pin tabix version in snippy

* fix tabix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants