Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sambamba: add linux-aarch64 build #46735

Merged
merged 5 commits into from
Jul 4, 2024
Merged

Conversation

martin-g
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

martin-g added a commit to martin-g/conda-forge-pinning-feedstock that referenced this pull request Mar 25, 2024
Needed by Bioconda/samtools
(bioconda/bioconda-recipes#46735)

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@mencian mencian added the aarch64 Related to adding linux-aarch64 support label Mar 25, 2024
@martin-g
Copy link
Contributor Author

This PR needs a linux-aarch64 build of conda-forge/ldc.
Its arch migration depends on the migration of the libconfig feedstock: https://conda-forge.org/status/migration/aarch64andppc64leaddition
libconfig is being worked on at conda-forge/libconfig-feedstock#7

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g
Copy link
Contributor Author

martin-g commented Jul 2, 2024

@BiocondaBot please fetch artifacts

@BiocondaBot
Copy link
Collaborator

Package(s) built are ready for inspection:

Arch Package Zip File / Repodata CI Instructions
linux-64 sambamba-1.0.1-h6f6fda4_2.tar.bz2 LinuxArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the LinuxArtifacts directory: conda install -c ./packages <package name>
osx-64 sambamba-1.0.1-hce90c57_2.tar.bz2 OSXArtifacts.zip Azure
showYou may also use conda to install after downloading and extracting the zip file. From the OSXArtifacts directory: conda install -c ./packages <package name>
linux-aarch64 sambamba-1.0.1-hc099486_2.tar.bz2 repodata.json CircleCI
showYou may also use conda to install:conda install -c https://output.circle-artifacts.com/output/job/fed174bb-9219-46c5-9029-0140cacdd3f9/artifacts/0/tmp/artifacts/packages <package name>

Docker image(s) built:

Package Tag CI Install with docker
sambamba 1.0.1--h6f6fda4_2 Azure
showImages for Azure are in the LinuxArtifacts zip file above.gzip -dc LinuxArtifacts/images/sambamba:1.0.1--h6f6fda4_2.tar.gz | docker load

@martin-g
Copy link
Contributor Author

martin-g commented Jul 2, 2024


mgrigorov in 🌐 euler-arm-22 in /tmp/sambamba via 🅒 test123 took 5s 
❯ tar xvf sambamba-1.0.1-hc099486_2.tar.bz2                                                                                                                                                                (test123) 
info/files
info/run_exports.json
info/test/run_test.sh
info/hash_input.json
info/has_prefix
info/recipe/build.sh
info/index.json
info/paths.json
info/recipe/0001-fix-osx-compile.patch
info/recipe/meta.yaml.template
info/recipe/meta.yaml
info/recipe/conda_build_config.yaml
info/about.json
info/licenses/LICENSE
info/git
bin/sambamba

mgrigorov in 🌐 euler-arm-22 in /tmp/sambamba via 🅒 test123 
❯ file bin/*                                                                                                                                                                                               (test123) 
bin/sambamba: ELF 64-bit LSB pie executable, ARM aarch64, version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for GNU/Linux 3.7.0, with debug_info, not stripped

mgrigorov in 🌐 euler-arm-22 in /tmp/sambamba via 🅒 test123 
❯ ./bin/sambamba                                                                                                                                                                                           (test123) 

sambamba 1.0.1
 by Artem Tarasov and Pjotr Prins (C) 2012-2023
    LDC 1.38.0 / DMD v2.108.1 / LLVM12.0.0 / bootstrap LDC - the LLVM D compiler (1.38.0)


Usage: sambamba [command] [args...]

  Available commands:

    view        view contents and convert from one format
                to another (SAM/BAM/JSON/UNPACK)
    index       build index (BAI)
    merge       merge files (BAM)
    sort        sort file (BAM)
    slice       slice file (BAM using BED)
    markdup     mark or remove duplicates (BAM)
    subsample   subsample (BAM)
    flagstat    output statistics (BAM)
    depth       output statistics (BAM)
    validate    simple validator (BAM)

  No longer recommended:

    mpileup     parallel execution of samtools (BAM)

To get help on a particular command, call it without args.

Global options

    -q          quiet mode (do not show banner)

For bug reports and feature requests see

       https://github.com/biod/

LGTM!

@martin-g
Copy link
Contributor Author

martin-g commented Jul 2, 2024

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Jul 2, 2024
@martin-g
Copy link
Contributor Author

martin-g commented Jul 2, 2024

Note: The CircleCI VM should be restored back to medium after merging this PR!

@corneliusroemer
Copy link
Member

Fabulous! You think the build got stuck due to OOM, hence switching to large runner? In that case we can close conda-forge/ldc-feedstock#53

@corneliusroemer
Copy link
Member

corneliusroemer commented Jul 4, 2024

Why should the circleci size be restored to medium? Do we think the problem is temporary?

Oh I see, it's a global setting, not per recipe. Sorry I missed that.

Copy link
Member

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martin-g martin-g merged commit bb42706 into bioconda:master Jul 4, 2024
6 checks passed
@martin-g martin-g deleted the aarch64-sambamba branch July 4, 2024 11:36
@martin-g martin-g mentioned this pull request Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants