Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming clades #289

Open
mortonjt opened this issue Apr 12, 2021 · 1 comment
Open

Renaming clades #289

mortonjt opened this issue Apr 12, 2021 · 1 comment

Comments

@mortonjt
Copy link
Collaborator

mortonjt commented Apr 12, 2021 •
edited
Loading

Right now, the y_i renaming of internal nodes is a bit jarring.
Perhaps we should enable renaming of only internal nodes that don't have names with something like clade_i.

The one thing to watch out for is internal node duplicates generated from tax2tree.
@mortonjt mortonjt mentioned this issue Apr 12, 2021
Open
@mortonjt
Copy link
Collaborator Author

One final comment

  1. This function will be compatible with the output of tax2tree that will enable annotation of internal nodes
  2. This function will eventually deprecate rename_internal_nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mortonjt