Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TRUE/FALSE is caught when validating sample-sheets. #188

Open
charles-cowart opened this issue Mar 19, 2024 · 2 comments
Open

Ensure TRUE/FALSE is caught when validating sample-sheets. #188

charles-cowart opened this issue Mar 19, 2024 · 2 comments
Assignees

Comments

@charles-cowart
Copy link
Collaborator

Sample-sheets must now use 'True' or 'False' explicitly. Ensure validation catches this so that processing doesn't begin before this error is caught (ValueError: 'TRUE' is not a valid value for BarcodesAreRC).

@charles-cowart charles-cowart self-assigned this Mar 19, 2024
@ackermag
Copy link

This is a real problem for people generating the sample_sheets who want to check that they are correctly formatted because the default viewer is Excel. Excel will automatically convert any version of true and false to TRUE and FALSE with central justification in the cell. In order to correct this, the SRA/processor of data needs to remember to convert to 'True' and 'False'. Why can't the code accept any version of true and false.

@charles-cowart
Copy link
Collaborator Author

This is a real problem for people generating the sample_sheets who want to check that they are correctly formatted because the default viewer is Excel. Excel will automatically convert any version of true and false to TRUE and FALSE with central justification in the cell. In order to correct this, the SRA/processor of data needs to remember to convert to 'True' and 'False'. Why can't the code accept any version of true and false.

We used to be able to do this, but Daniel and Rob asked that I remove it. @wasade, I've been getting frequent requests to let True and False be case in-sensitive. If someone uses Excel to make a manual correction in a sample-sheet, it will instantly become invalid because Excel implicitly converts all forms of true and false to TRUE and FALSE. Would you mind if this made a comeback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants