Adding finalized skeleton of web pipeline 👍ready to be merged👍 #117
Conversation
|
|
||
| commands = [] | ||
| for data_type, command in split: | ||
| print "INPUT: ", data_type, command |
There was a problem hiding this comment.
Can you remove this and all the following print statements?
|
👍 |
| @@ -17,11 +17,8 @@ install: | |||
| - pip install . | |||
| script: | |||
| - qiita_env make_test_env | |||
| - nosetests --with-doctest | |||
| - nosetests --with-doctest --with-coverage --cover-package=coveralls | |||
There was a problem hiding this comment.
@squirrelo can you undo this?
ElDeveloper
changed the title
|
This should be ready for merge! The instructions I suggest are to pull down this branch then: qiita_env drop_demo_env
qiita_env make_demo_env # you need an internet connection for this step
python qiita_pet/webserver.pyIn a browser go to http://localhost:8888 and then create a new meta-analysis, it should take you through the end of the workflow. |
ElDeveloper
changed the title
|
|
||
| class AnalysisWaitHandler(BaseHandler): | ||
| @authenticated | ||
| def get(self, analysis_id): |
There was a problem hiding this comment.
Right now, with this implementation, people will be able to change the id in the URL to whatever they want and retrieve that analysis, whether or not they are supposed to have access to it. See #147
There was a problem hiding this comment.
Note: this is fine for the demo, but we should address it in the future
| self.r_server = Redis() | ||
| self.redis = Client() | ||
| self.redis.connect() | ||
| # self.redis = Client() |
There was a problem hiding this comment.
Are these lines here because we will use them after the demo, but don't want to use them right now?
|
@antgonza gave his blessing for this PR to be merged, if all is good someone else should merge this. |
|
Yep, all looks good to me! |
|
Thanks, guys! This looks good. But the fact that the code coverage is reduced makes me a little sick. |
Adding finalized skeleton of web pipeline ready to be merged
Still can't show results or have a proper working wait page, as those are dependent on the job running working, but you can now go through the entire pipeline and see how it looks.