Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating changelog #1357

Merged
merged 2 commits into from Aug 3, 2015
Merged

Conversation

josenavas
Copy link
Contributor

No description provided.

@josenavas josenavas mentioned this pull request Jul 8, 2015
28 tasks
@josenavas
Copy link
Contributor Author

I don't think we need to wait for the tests to pass in this one, please comment and we can merge, since it will be tested in the Transaction PR

@@ -25,6 +25,7 @@ http://qiime.org/documentation/file_formats.html#mapping-file-overview.
* `qiita-general` is now used as a default argument to `qiita-env start_cluster` and `qiita-env stop_cluster` if no cluster name is specified
* Qiita now now allows for processing of already demultiplexed data without any technical (barcode and primer) section of the read.
* Qiita now includes full portal support, limiting study and analysis access at below the qiita_db level. This allows one database to act as if subsets of studies/analyses are their own specific interface. Commands added for portals creation and maintenance, under `qiita db portal ...` and `qiita-env`. Portal specific web user interface support has also been added; each portal is fully CSS customizable.
* Qiita has been know modified to execute all the DB interactions using a transaction. The queue code present on the `SQLConnectionHandler` has been removed and a new `Transaction` object has been implemented. The system implements the singleton method and all the DB interaction through the code base are done through the `TRN` variable (`Transaction` instance) exposed through `qiita_db.sql_connection`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Qiita has been know modified to execute all the DB interactions using a transaction -> Qiita will execute all DB interactions in transactions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queue code present on the SQLConnectionHandler has been removed and a new Transaction object has been implemented -> The queue code was moved from SQLConnectionHandler to a new Transaction.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The system implements the singleton method and all the DB interaction through the code base are done through the TRN variable (Transaction instance) exposed through qiita_db.sql_connection. -> Can you explain what is a singleton method? Perhaps also a rephrase will be nice ...

@squirrelo
Copy link
Contributor

👍

antgonza added a commit that referenced this pull request Aug 3, 2015
@antgonza antgonza merged commit 3e551e8 into qiita-spots:transaction Aug 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants