Ebi improvements pet #1490
Ebi improvements pet #1490
Conversation
…ription tab and all qiita pet tests passing again
|
Depends on #1489 so review/merge that one first |
|
|
||
| @property | ||
| def is_submitted_to_ebi(self): | ||
| """Gets if the prep template has been submitted to EBI or not |
There was a problem hiding this comment.
This is minor - could you rephrase this from "Gets" to "Inquires"?
|
Don't forget the pep8 error |
| experiment_alias = self._get_experiment_alias(sample_name) | ||
| sample_prep = dict(self.samples_prep[sample_name]) | ||
| if self._ebi_sample_accessions[sample_name]: |
There was a problem hiding this comment.
Is it possible to pass in samples that aren't contained in self._ebi_sample_accessions? If so, would it be worthwhile to add a check?
There was a problem hiding this comment.
It shouldn't. samples is a subset of the samples in the sample template, and _ebi_sample_accessions has an entry for each of the samples in the sample template.
…nto ebi-improvements-pet
|
Comments addressed. |
| @@ -39,6 +39,9 @@ | |||
| 'public': | |||
| ('glyphicon glyphicon-eye-open', 'glyphicon glyphicon-globe', 'green')} | |||
|
|
|||
| ebi_linkifier = ('<a href="http://www.ebi.ac.uk/ena/data/view/{0}" ' | |||
There was a problem hiding this comment.
ebi_linkifier -> EBI_LINKIFIER
|
Just one comment, code looks good otherwise. I'll take a pass through the interface though. @mortonjt, did you review the interface? |
|
Nope. I'll try to take a look at the interface later today. Jamie On Thu, Oct 8, 2015 at 9:54 AM, Yoshiki Vázquez Baeza <
|
|
Thanks @josenavas , 👍 @mortonjt you can merge as soon as you are done testing. |
|
👍 |
Fixes the interface to show that EBI data in the corresponding spot.