Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch job #152

Merged
merged 27 commits into from
Jun 21, 2014
Merged

Launch job #152

merged 27 commits into from
Jun 21, 2014

Conversation

wasade
Copy link
Contributor

@wasade wasade commented Jun 20, 2014

No unit tests :( could probably add some for ClusterDispatch

antgonza and others added 20 commits June 18, 2014 13:40
@antgonza
deleting unused files
1eea1c6
@antgonza
adding ipython to setup.py
2752d0b
@antgonza
Merge branch 'master' of git://github.com/biocore/qiita into launch_job
274b7bc
@antgonza
Merge branch 'master' of git://github.com/biocore/qiita into launch_job
0962495
@antgonza
first pass
3c2116d
@wasade
Merge branch 'launch_job' of github.com:antgonza/qiita into launch_job
eb6c1db
@wasade
Catch parsing exception
ce73646
@wasade
Section check, decomposed parsing
510102d
@wasade
More ipython bits, added config manager to qiita_env
43ab398
@wasade
More stuff
7293649
@wasade
Merge branch 'master' of github.com:biocore/qiita into launch_job
efcc517 
Conflicts:
	qiita_db/job.py
@wasade
starting CRC is 0
9500dfe
@wasade
initial run_analysis
a140a57
@wasade
Merge branch 'master' of github.com:biocore/qiita into launch_job
c8e6919
@wasade
removed unit test
647318d
@wasade
added ClusterDispatch
06aa445
@wasade
added comment
b6185bb
@wasade
have travis create and spin up clusters
9304675
@wasade
updated test env config
3217982
@wasade
removed dirs
98b7f24
@antgonza
Copy link
Member

Ignoring the test comment, looks good to me.

@wasade
Copy link
Contributor Author

wasade commented Jun 21, 2014

Probably want to rename ClusterDispatch to Dispatcher or something. The use of cluster is redundant.

submit_sync and submit_async don't handle the different clusters yet but that logic is deferred to after the demo as it isn't clear right now how that will tie into the rest of the system, user roles, etc

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.56%) when pulling def3b8d on wasade:launch_job into ef1fb15 on biocore:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.21%) when pulling 8d7aa41 on wasade:launch_job into ef1fb15 on biocore:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.43%) when pulling 8d7aa41 on wasade:launch_job into ef1fb15 on biocore:master.

@josenavas
Copy link
Contributor

👍

@ElDeveloper
Copy link
Member

Tests pass and we reviewed with @wasade presenting the code so I'm merging.
fingers_crossed

ElDeveloper added a commit that referenced this pull request Jun 21, 2014
@ElDeveloper
Merge pull request #152 from wasade/launch_job
00c29a3 
Launch job
@ElDeveloper ElDeveloper merged commit 00c29a3 into qiita-spots:master Jun 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wasade @antgonza @coveralls @josenavas @ElDeveloper