Analysis waiting page handshake

[squirrelo]

Removes string parsing element of JSON handshake.

[coveralls]

Coverage remained the same when pulling dcfb331 on squirrelo:handshake into 59e835c on biocore:master.

[adamrp]

The code looks fine, but what is test.txt? It looks like it's in the root qiita directory. Did you mean to include it, or was this the result of another git add .?

[squirrelo]

I honestly have no idea where that came from. And no more git add . after the last fiasco....

[coveralls]

Coverage remained the same when pulling da4248d on squirrelo:handshake into 59e835c on biocore:master.

[josenavas]

Did you pull form upstream? This file was added by mistake in one of my PR but I already solved in the past.

Just to make sure, can you also run the tests and make sure that this files does not get generated?

[squirrelo]

Yeah I pulled from upstream. Doesn't seem like it's coming from tests.

[squirrelo]

Also this should be ready to merge if there are no more comments.

[adamrp]

I personally don't like having the javascript visible in the HTML template like this. What do other devs think?

[squirrelo]

It's going to be visible whether it's in a separate file or within the page itself. There's no security to be had by moving it.

[adamrp]

Was not a security concern, just a code clutter concern

[adamrp]

Also, with respect to the test.txt file, you should be able to run git clean -xdf in your git folder and it should go away if it's not part of the repository (just be very careful, because this will remove anything that's not part of the repo!)

[squirrelo]

Ah. My logic is that the javascript in the head of templates is always page-specific. I figured that would be the best way to keep things organized and together.

[ElDeveloper]

Closing this as the git history seems to be corrupted, @squirrelo agreed to open a new PR for this.