Commands datatype table #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this commit ports over the contents of the previously existing repository. Fixes qiita-spots#59
| @@ -107,7 +107,7 @@ def _sql_executor(self, sql, sql_args=None, many=False): | |||
| err_sql = cur.mogrify(sql, sql_args) | |||
| else: | |||
| err_sql = cur.mogrify(sql, sql_args[0]) | |||
| except IndexError: | |||
| except (IndexError, TypeError): | |||
There was a problem hiding this comment.
In what context would a TypeError be raised above?
There was a problem hiding this comment.
in case that sql_args is None
There was a problem hiding this comment.
In that case, i think this try/except can be replaced with:
if sql_args and sql_args[0] and isinstance(sql_args[0], Iterable):
err_sql = cur.mogrify(sql, sql_args[0])
else:
err_sql = cur.mogrify(sql, sql_args)right?
There was a problem hiding this comment.
you could even remove the and sql_args[0] part of the if clause, i think
There was a problem hiding this comment.
Sounds good, fix pushed.
|
Looks good to me, anyone else so we can merge? |
|
After that comment about the nested try/excepts is addressed, I give it the 👍 |
|
This is ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a join table that links a command up to the datatypes it can be run on. Needed so we can programmatically populate the commands selection for each datatype.