public/user listing studies #1831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review, thanks! |
|
Changes Unknown when pulling 972faef on antgonza:listing-studies into * on biocore:master*. |
|
👍 |
| if not name: | ||
| name = email | ||
| info['shared'].append((email, name)) | ||
| if info['shared_with_name'] and info['shared_with_email']: |
There was a problem hiding this comment.
It looks like these lines of code where bugs introduced in the previous PR, which means that the tests do not capture this case. I recommend to add a specific test that will capture this case so it doesn't repeat.
|
Few comments. However, the sample selection doesn't work with this branch. Unsure where the bug is, but neither the |
|
Changes Unknown when pulling 279ed36 on antgonza:listing-studies into * on biocore:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue introduced in the initial listing PR, adds 2 lists with only one control set, and fixes some indentation issues in the js.