Last touches #1874
Merged
Last touches #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review: @ElDeveloper and @josenavas |
| @@ -1359,10 +1359,27 @@ def validate(self, restriction_dict): | |||
| if datatype == datetime: | |||
| val = str(val) | |||
| try: | |||
| datetime.strptime(val, '%m/%d/%y %H:%M:%S') | |||
| datetime.strptime(val, '%m/%d/%Y %H:%M:%S') | |||
There was a problem hiding this comment.
Argh! That hurts! So sad that datetime doesn't support the "or" operator. What about something like this?
formats = ['%m/%d/%Y %H:%M:%S', '%m/%d/%Y %H:%M', '%m/%d/%Y %H', '%m/%d/%Y', '%m/%Y', '%Y']
dt = None
for fmt in formats:
try:
dt = datetime.strptime(val, fmt)
except ValueError:
pass
if dt is None:
warning_msg.append(....)
|
Thanks @antgonza few comments |
|
👍 |
|
👍 given tests pass |
|
@antgonza there are a couple of real errors in here. Should be easy to fix though. |
|
Thanks, just pushed the fixes. |
|
Changes Unknown when pulling b47e486 on antgonza:last-touches into * on biocore:str-ing_info_fles*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing the timestamp fix but want to see how the tests go ...