Allowing updating the oauth2 info #1965
Conversation
|
👍 , when tests pass. @ElDeveloper, could you review? |
|
Changes Unknown when pulling 432df2c on josenavas:plugin-installation-update-keys into * on biocore:plugin-installation*. |
| '"%s" version "%s" does not match the one in the ' | ||
| 'system' % (name, version)) | ||
| if update: | ||
| sql = """INSERT INTO qiita.oauth_identifiers |
There was a problem hiding this comment.
does this stand to make multiple inserts and is that expected?
There was a problem hiding this comment.
I think I don't understand your question? This is inserting if it doesn't already exists.
There was a problem hiding this comment.
I think I understand your question now (thanks @antgonza ). The select that can return a lot of row is inside an EXISTS and it is only used to check if that row already exists or not. The first select, can only return 1 row, since the values are passes as a parameter, i.e. it is effectively doing something similar to SELECT 42.
I don't know why I was not allowing the update of the oauth2 info before, but I allow it now. This will allow to run the plugin tests easier.