fix #1971 #1989
fix #1971 #1989
Conversation
|
Changes Unknown when pulling 881363b on antgonza:fix-1971 into * on biocore:master*. |
| @@ -173,10 +173,14 @@ def study_prep_get_req(study_id, user_id): | |||
| info['start_artifact_id'] = start_artifact.id | |||
| info['youngest_artifact'] = '%s - %s' % ( | |||
| youngest_artifact.name, youngest_artifact.artifact_type) | |||
| info['ebi_experiment'] = (True | |||
There was a problem hiding this comment.
I think this line can be shortened to bool(prep.ebi_experiment_accessions), at least that's what the if would do IIRC.
| <span id="prep-header-{{prep['id']}}">{{prep['name']}} - ID {{prep['id']}} - {{prep['status']}}</span><br/> | ||
| <span id="prep-header-{{prep['id']}}"> | ||
| {% if prep['ebi_experiment'] %} | ||
| <img src="{% raw qiita_config.portal_dir %}/static/img/ena.png" style="width:20px;height:20px;"> |
There was a problem hiding this comment.
Should this be a link to the accession itself?
There was a problem hiding this comment.
Perhaps, no strong feelings. I think it's fine as it is. If we add, suggest adding to the full study as EBI doesn't have a group preparation (preparation info file) idea.
There was a problem hiding this comment.
Yeah, no strong ( 💪 ) feelings on this matter either. OK to leave as is.
|
Changes Unknown when pulling c21d4bc on antgonza:fix-1971 into * on biocore:master*. |
|
Random error, restarted job and now is passing. Ready to merge. |
Just fixing the issue.
Now, if the prep has been submitted to EBI you will see:
