Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1645 #1990

Merged
merged 1 commit into from
Nov 7, 2016
Merged

fix #1645 #1990

merged 1 commit into from
Nov 7, 2016

Conversation

antgonza
Copy link
Member

@antgonza antgonza commented Nov 7, 2016

This was an issue with displaying the templates. I wanted to add a test but wasn't sure how to, perhaps it's not easy to do as this is related to: #567.

@ElDeveloper, could you review?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 5b12244 on antgonza:fix-1645 into * on biocore:master*.

@josenavas
Copy link
Contributor

That's interesting - code looks good but I'm unsure if it will solve the issue - let's wait until @ElDeveloper checks it

@ElDeveloper
Copy link
Member

I think this looks good, @josenavas, I believe this will work. Look at the traceback we are getting:

ERROR:
'ascii' codec can't decode byte 0xf0 in position 15: ordinal not in range(128)
TRACE:
Traceback (most recent call last):

File "/home/qiita/.virtualenvs/qiita/lib/python2.7/site-packages/tornado/web.py", line 1141, in _when_complete
callback()

File "/home/qiita/.virtualenvs/qiita/lib/python2.7/site-packages/tornado/web.py", line 1162, in _execute_method
self._when_complete(method(*self.path_args, **self.path_kwargs),

File "/home/qiita/.virtualenvs/qiita/lib/python2.7/site-packages/tornado/web.py", line 2297, in wrapper
return method(self, *args, **kwargs)

File "/home/qiita/qiita/qiita_core/util.py", line 121, in wrapper
return func(*args, **kwargs)

File "/home/qiita/qiita/qiita_pet/handlers/analysis_handlers.py", line 285, in post
% (qiita_config.portal_dir, level, msg))

UnicodeDecodeError: 'ascii' codec can't decode byte 0xf0 in position 15: ordinal not in range(128)

@antgonza
Copy link
Member Author

antgonza commented Nov 7, 2016

I actually tested and it works.

@ElDeveloper ElDeveloper merged commit b937dea into qiita-spots:master Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants