Fix 633 #1992
Merged
Fix 633 #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 787b8ad on antgonza:fix-633 into * on biocore:master*. |
josenavas
suggested changes
Nov 8, 2016
| user_study_set = user.user_studies.union(user.shared_studies) | ||
| study_set = user_study_set - Study.get_by_status('public') | ||
| else: | ||
| portal_set = Portal(qiita_config.portal).get_studies() |
There was a problem hiding this comment.
Why is this line needed? Study.get_by_status should already return the studies that are only visible in the current portal. If not, there is a bug in that function so I would prefer to change that function rather than patch it here.
|
Changes Unknown when pulling 60a53c9 on antgonza:fix-633 into * on biocore:master*. |
josenavas
approved these changes
Nov 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussing with @josenavas we agreed that the easiest solution was to simply add those non public studies to the admins listing.