Listing tags

[antgonza]

ToDo:

• make tests pass
• test in qiita-test env

[coveralls]

Coverage increased (+0.03%) to 91.613% when pulling c457554 on antgonza:listing-tags into 2795046 on biocore:master.

[antgonza]

This should be ready for review after #2088 is merged. This code has been deployed in the test env and seems to be working fine. Note that I had to update some js and css libraries

Example of functionality, see how the "regular" search and the tags interact nicely:

[coveralls]

Coverage increased (+0.02%) to 91.603% when pulling bba8f03 on antgonza:listing-tags into 2795046 on biocore:master.

[wasade]

should there be negative test cases?

[antgonza]

Thanks @wasade note that this is based on: #2088 ....

[wasade]

Should I not review this then?

[josenavas]

@antgonza can you pull from upstream/master?

[antgonza]

pull from upstream/master ready. Note that currently we are using tag-it also to display it and it looks like this:

but I could simplify things so it looks like this:

I really don't have a preference but wanted to ask ...

[coveralls]

Changes Unknown when pulling fdb6723 on antgonza:listing-tags into ** on biocore:master**.

[antgonza]

@wasade, @josenavas, @ElDeveloper, could you review?

[josenavas]

Thanks @antgonza code looks good!

Answering your last question - I think either looks fine, I don't have a strong preference. What I don't really like is the position of the filter. i.e. I don't like it showing inside the table. Is it easy to have on top of the table (i.e. above the headers?). The reason why I don't like it there is because it looks like only applies to the top table, but it should be applied to both tables (private and public studies).

Do you think that change can be done easily?

[antgonza]

Not difficult at all, we have 3 options:

1. what we have now
2. this:
3. or this:

[ElDeveloper]

Option 2 looks great 👍

[josenavas]

My vote goes to 2 - I like when things are modular and can be moved around!!! :D

[antgonza]

This is the pushed version:

[coveralls]

Changes Unknown when pulling e306f32 on antgonza:listing-tags into ** on biocore:master**.

[wasade]

merge?

[ElDeveloper]