Status base class

[squirrelo]

This adds a decorator to the QiitaStatusObject that can check what the status of the object is and stop functions from running if not correct. examples:

class Study(QiitaStatusObject):
...
    @self.check_status("public", exclude=True)
    def delete_something(self):
        ...

Would only allow deletions if the study was not public. Makes for a nice way of having data integrity with everything still not living in memory.

This needed some changes to the database, mainly what the names of the status tables are called and changing every status column to be named status. Only affected the study_status, required_sample_info, and sample_status tables.

This also adds a subtle change to the main QiitaObject - a _table variable that will hold the name of the table that the object's id comes from, e.g. for the Study object we would have self._table = "study".

[josenavas]

I think it will make sense to accept a list of str, so we can check that the status is in such list.

[josenavas]

2 minor comments @squirrelo

Thanks!!!

[squirrelo]

Thanks @josenavas I've integrated the changes.

[josenavas]

If you are going to do the conversion anyways, I would say that you just should accept a list, not a string and a list.

[squirrelo]

Eh, to me it's easier and more useful to accept both and just do the conversion. That way if you are doing just one status type you can forget the list and it still works.

[wasade]

spaces around or

[wasade]

it looks like exclude doesn't matter, why not just dbstatus not in status or dbstatus in status... but, under what situation would this not evaluate True?

[squirrelo]

Exclude is a flag on whether or not you want to have the database status in the list or not in the list (excluded).
The way this evaluates, when exclude is true dbstatus must not be in database, and if exclude is false, dbstatus must be in database.

[coveralls]

Changes Unknown when pulling d8de6cc on squirrelo:status_base_class into * on biocore:master*.

[coveralls]

Changes Unknown when pulling 80ecedf on squirrelo:status_base_class into * on biocore:master*.

[coveralls]

Changes Unknown when pulling 8ee6d86 on squirrelo:status_base_class into * on biocore:master*.

[coveralls]

Changes Unknown when pulling f76344a on squirrelo:status_base_class into * on biocore:master*.

[coveralls]

Changes Unknown when pulling 4405814 on squirrelo:status_base_class into * on biocore:master*.