Study and StudyPerson object #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,3 @@ | |||
| #!/usr/bin/env python | |||
| from __future__ import division | |||
|
|
|||
| """ | |||
There was a problem hiding this comment.
Can you provide a full module level docstring? The one that is currently in is a placeholder. You can see an example here
| from .base import QiitaStatusObject, QiitaObject | ||
| from .data import RawData, PreprocessedData, ProcessedData | ||
| from .user import User | ||
|
|
|
@squirrelo it looks like your documentation is outdated. Please, update all your docs and the related code. Check also the link I provided before to check the numpy docstring format. Let me know when you're done with all these changes and I'll provide a full review. It's a waste of time doing partial reviews. |
|
Yeah, seems so. Updating it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41 #55
Finally the big thing that all the tiny pull requests were for.
This is the study object itself, as well as the study person object that holds info on the people involved in a study. Please check this over and let me know if I missed any wanted functionality as well as the usual code stuff.
Also, the delete functionality is purposely not implemented currently. It will be hairy to do and not worth the time right now as the other objects need development an we aren't really deleting anything right now.