Issue 855 #900
Issue 855 #900
Conversation
|
@josenavas, conflicts |
| JOIN qiita.processed_data_status pds | ||
| ON pds.processed_data_status_id=pd.processed_data_status_id | ||
| WHERE pds.processed_data_status=%s""" | ||
| studies = [x[0] for x in |
There was a problem hiding this comment.
can this be a set? See #961
|
I think this is looking good, and it works great! The only other thing that I noticed (aside from the minor comments above), is that the icon in the "show prep template summary" button should probably removed, as the eye or the crossed-out eye imply information about the privacy status of the data objects.
|
|
Forgot to add, 👍. |
|
Good catch @ElDeveloper I've also removed the eye icon from the show sample template summary so the interface is consistent. I tried to find another icon, but given that we already have the test and I cannot find another "good enough" icon, I just left the text. Thanks for the reviews! |
|
Thanks!! That seems reasonable (re: button). 👍 Yoshiki Vázquez-Baeza
|
|
That's a new one! I received a "Killed" message... I re-started the build... |
|
Yeah, I was getting that last week. I've started taking note of the On (Mar-25-15|21:49), josenavas wrote:
|
| @@ -14,4 +14,14 @@ | |||
| </tr> | |||
| {% end %} | |||
| </table> | |||
| {% if btn_to_show == 'request_approval' %} | |||
| <a class="btn btn-default glyphicon glyphicon-eye-open" onClick="request_approval({{pd_id}});" style="word-spacing: -10px;"> Request Approval</a> | |||
There was a problem hiding this comment.
Can you be more specific, users will not know what approval means? Perhaps, "Request making this data public". Same to the other buttons.
|
IMOO it's confusing that awaiting for awaiting for private approval has an orange eye and when public a green one. The confusing part is that private has a gray eye. What about: waiting for approval: orange open eye + 'glyphicon glyphicon-lock', private yellow open eye + 'glyphicon glyphicon-lock', public green open eye + 'glyphicon glyphicon-globe'? |
|
Two comments. After those 👍 |
|
Build restarted ⏰ |
|
... and again. |
|
This is getting annoying... we need to find a solution for that... |
|
I've increased the timeout time to 10 sec instead of 5, to see if now the tests pass.... |
|
Now a redis connection problem 😢 re-starting... |
|
Ok, I got the tests passing now. I'm going to re-start them once to see if they are passing again. If so, this should be ready to final review/merge |
|
Thanks @josenavas! |
|
💥 |
|
|
Fixes #855
I've moved the status column from the study object to the processed data and now the status of the study is inferred by the status of its processed data.
I've all the tests passing (at least on my machine) but I don't think the functionality is currently consistent!
The issue is that the metadata pipeline will show all the processed data for a given study, even if a given processed data is not public... Since this PR is making a deep change in the db structure and has impacts in a lot of parts of the codebase; I think the most secure way of moving this forward is making a PR so people can download the PR and check different contexts, in case that I missed something.
Missing things (that I can think of - please add as needed):
make public / revert to sandbox / etcbuttons are in per processed data basis.