Metadata object #93
Metadata object #93
Conversation
|
Yay!!! Test passed and our coverage is in green!! 91%!!! |
|
|
||
| def __eq__(self, other): | ||
| r"""Self and other are equal based on type and ids""" | ||
| if type(self) != type(other): |
There was a problem hiding this comment.
I think isinstance would work great here.
|
Couple of minor comments, excited to try this out! |
|
Thanks @ElDeveloper !! |
|
Congratulations! On Jun 17, 2014, at 8:23 PM, "josenavas" <notifications@github.commailto:notifications@github.com> wrote: Aaaaand the last important object is in!! I was struggling with a couple of errors and a merge conflict, but it is finally here!! The whole idea of the Sample/Prep templates objects is to behave as a dict of dicts, in which the first level of keys are the sample ids and the second one are the metadata category headers. Anyone available to review this?? You can merge this Pull Request by running git pull https://github.com/josenavas/QiiTa metadata Or view, comment on, or merge it at: Commit Summary
File Changes
Patch Links: — |
|
👍 after tests pass |
Aaaaand the last important object is in!! I was struggling with a couple of errors and a merge conflict, but it is finally here!!
The whole idea of the Sample/Prep templates objects is to behave as a dict of dicts, in which the first level of keys are the sample ids and the second one are the metadata category headers.
Anyone available to review this??