Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bipy/app/test/test_util.py references /tmp, and general clean-up to temp file naming in app controllers #71

Closed
gregcaporaso opened this issue Jan 31, 2014 · 2 comments

Comments

@gregcaporaso
Copy link
Contributor

All references to /tmp should be replaced with tempfile.tempdir.

We also really need to re-do the get_tmp_filename function/method to better use of python's tempfile module. One way to do that that might be relatively painless would be to keep the interface of that function/method the same, but internally use the tempfile module. Thoughts on that? Note that cogent.app.util.get_tmp_filename is very widely used in QIIME, though it falls low in my list because it's imported in qiime.util, where some QIIME-specific defaults (e.g., temp_dir=get_qiime_temp_dir()) are set, and then imported from there.

@gregcaporaso gregcaporaso mentioned this issue Jan 31, 2014
@Jorge-C
Copy link
Contributor

Jorge-C commented Jan 31, 2014

We also need to replace the teardown_module function in bipy/app/tests/test_util.py with more fine grained teardown methods in the classes that need it.

@jairideout
Copy link
Contributor

Closing as the application controller code is now in burrito. Opened an issue there to keep track of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants