New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two samples with zero total branch length produce a nan in output #16

Open

wasade opened this issue Jun 20, 2017 · 2 comments

Member

wasade commented Jun 20, 2017

Whereas they should produce a zero

Member Author

wasade commented Jun 20, 2017

...actually, I do not fully understand this yet.

wasade closed this as completed

wasade reopened this

Member Author

wasade commented Jun 20, 2017

Okay, ya, in c++, 0 / 0 is nan. This can arise if two samples are represented by a single identical feature. Their distance is zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment