Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tiling #161

Merged
merged 10 commits into from
Nov 25, 2021
Merged

Fix tiling #161

merged 10 commits into from
Nov 25, 2021

Conversation

constantinpape
Copy link
Contributor

Fixes #157

@github-actions github-actions bot added the bug Something isn't working label Nov 23, 2021
@constantinpape constantinpape marked this pull request as ready for review November 23, 2021 21:59
@constantinpape
Copy link
Contributor Author

@FynnBe this should be good to go now.
In addition to fixing the tiling for models with channel last this fixes a few more bugs with prediction, in particular enabling prediction with models with multiple input/output tensors, which failed before due to a check done at a wrong position.
It also updates the conftest to make use of the new models and removes FruNet from it, which is deprecated.

@constantinpape
Copy link
Contributor Author

The issues with loading torch models are back .... :(.

@FynnBe
Copy link
Member

FynnBe commented Nov 24, 2021

The issues with loading torch models are back .... :(.

well we are not filtering out pre pytorch 1.10 models here yet... ( oh darn, just noticed that I called the list pre_3_10 (got confused with the python version I guess^^)
Anyhow, I'm not sure that's really the fix, also because then we just don't test them, now that even python 3.7 goes along with pytorch 1.10...

@constantinpape
Copy link
Contributor Author

well we are not filtering out pre pytorch 1.10 models here yet... ( oh darn, just noticed that I called the list pre_3_10 (got confused with the python version I guess^^)
Anyhow, I'm not sure that's really the fix, also because then we just don't test them, now that even python 3.7 goes along with pytorch 1.10...

Maybe we should pin to an older pytorch version in the tests for now.
And we can try to update the relevant models to pytorch 1.10 next week.

@constantinpape
Copy link
Contributor Author

@FynnBe I pinned to "pytorch<3.10" for now so we can run all the tests.
I will try to update the models next week so that we can run with 3.10.
This is good to go from my side now, let me know if you think there are any more changes required.

@FynnBe FynnBe merged commit 4e1babf into main Nov 25, 2021
@FynnBe FynnBe deleted the fix-tiling branch November 25, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiling assumes channel first input
2 participants