Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offset in ImplicitOutputShape is cast to int #280

Closed
constantinpape opened this issue Nov 23, 2021 · 2 comments · Fixed by #282
Closed

offset in ImplicitOutputShape is cast to int #280

constantinpape opened this issue Nov 23, 2021 · 2 comments · Fixed by #282
Assignees
Labels
bug Something isn't working

Comments

@constantinpape
Copy link
Collaborator

This is an issue because we calculate the output shape as out_shape = in_shape * scale + offset * 2, so we need to allow for fractional output values in case the target value for offset * 2 is an odd number.

@FynnBe
Copy link
Member

FynnBe commented Nov 23, 2021

related question: for such uneven case, how would one determine the relative position of output wrt input?
(we might want to ignore this one for now and just leave it to the judgement of any consumer software)

@constantinpape
Copy link
Collaborator Author

constantinpape commented Nov 23, 2021

related question: for such uneven case, how would one determine the relative position of output wrt input?
(we might want to ignore this one for now and just leave it to the judgement of any consumer software)

I think this case mostly comes up for the channel axes in order to specify the number of output channels as scale=0, offset=n_channels/2. So I would ignore this issue for now.

@FynnBe FynnBe mentioned this issue Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants