Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float offset #282

Merged
merged 3 commits into from
Nov 23, 2021
Merged

Float offset #282

merged 3 commits into from
Nov 23, 2021

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Nov 23, 2021

closes #280

enforcing that offset is a multiple of 0.5

@constantinpape
Copy link
Collaborator

The changes look good, but the tests now all fail. Do we maybe enforce float values with these changes?
That should not be the case! Maybe we need List[Union[float, int]]?

@FynnBe
Copy link
Member Author

FynnBe commented Nov 23, 2021

ints are perfectly valid floats so we don't need any Union there. The whole list of floats threw the initial validation off...
anyhow, this new error ModuleNotFoundError: No module named 'conda._vendor.auxlib' is very obscure and seems unrelated!?

https://github.com/bioimage-io/spec-bioimage-io/runs/4299589635?check_suite_focus=true

@constantinpape
Copy link
Collaborator

ints are perfectly valid floats so we don't need any Union there. The whole list of floats threw the initial validation off...
anyhow, this new error ModuleNotFoundError: No module named 'conda._vendor.auxlib' is very obscure and seems unrelated!?

I restarted the tests. Let's see if it happens again, but yes it looks unrelated.

@constantinpape
Copy link
Collaborator

Ok, it's still failing.
@k-dominik any idea what might cause the test failure in the conda-build test:

  File "/usr/share/miniconda/lib/python3.9/site-packages/conda_build/environ.py", line 483, in meta_vars
    d.update(get_git_info(git_exe, git_dir, meta.config.debug))
  File "/usr/share/miniconda/lib/python3.9/site-packages/conda_build/environ.py", line 191, in get_git_info
    from conda._vendor.auxlib.packaging import _get_version_from_git_tag
ModuleNotFoundError: No module named 'conda._vendor.auxlib'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

offset in ImplicitOutputShape is cast to int
2 participants