-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update halo description #278
Conversation
Not sure if this helps to make it more clear. Interpreting the comment from @uschmidt83 in stardist/stardist#171, I think that we mention "crop" here might be confusing. Maybe we could also link to the reference implementation (https://github.com/bioimage-io/core-bioimage-io-python/blob/main/bioimageio/core/prediction.py#L192-L234) here? |
Note also bioimage-io/core-bioimage-io-python#157. |
yes, that's why I removed 'crop' and only left one 'not cropped'...
always a good idea 👍 |
I think we can go ahead with this to merge the code changes; the description is already a bit better and we can work on improving it further. (I think the proper thing here would be to include an illustration; there is a very nice one @esgomezm has that could be used for it.) |
# Conflicts: # bioimageio/spec/model/v0_3/schema.py
A description needing additional explanation is not good enough... stardist/stardist#171 (comment) This is an attempt to fix that.