Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update halo description #278

Merged
merged 8 commits into from
Dec 8, 2021
Merged

Update halo description #278

merged 8 commits into from
Dec 8, 2021

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented Nov 23, 2021

A description needing additional explanation is not good enough... stardist/stardist#171 (comment) This is an attempt to fix that.

@constantinpape
Copy link
Collaborator

Not sure if this helps to make it more clear. Interpreting the comment from @uschmidt83 in stardist/stardist#171, I think that we mention "crop" here might be confusing.

Maybe we could also link to the reference implementation (https://github.com/bioimage-io/core-bioimage-io-python/blob/main/bioimageio/core/prediction.py#L192-L234) here?

@constantinpape
Copy link
Collaborator

Note also bioimage-io/core-bioimage-io-python#157.

@FynnBe
Copy link
Member Author

FynnBe commented Nov 23, 2021

Not sure if this helps to make it more clear. Interpreting the comment from @uschmidt83 in stardist/stardist#171, I think that we mention "crop" here might be confusing.

yes, that's why I removed 'crop' and only left one 'not cropped'...

Maybe we could also link to the reference implementation (https://github.com/bioimage-io/core-bioimage-io-python/blob/main/bioimageio/core/prediction.py#L192-L234) here?

always a good idea 👍

@github-actions github-actions bot added ci Continuous Integration github_actions Pull requests that update Github_actions code labels Nov 27, 2021
@FynnBe
Copy link
Member Author

FynnBe commented Nov 27, 2021

@FynnBe FynnBe mentioned this pull request Nov 29, 2021
@constantinpape
Copy link
Collaborator

I think we can go ahead with this to merge the code changes; the description is already a bit better and we can work on improving it further. (I think the proper thing here would be to include an illustration; there is a very nice one @esgomezm has that could be used for it.)

# Conflicts:
#	bioimageio/spec/model/v0_3/schema.py
@FynnBe FynnBe merged commit 9bb4137 into main Dec 8, 2021
@github-actions github-actions bot deleted the halo_descr branch December 8, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants