Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve symlinks when transforming absolute to relative paths during serialization #438

Merged
merged 6 commits into from May 3, 2022

Conversation

FynnBe
Copy link
Member

@FynnBe FynnBe commented May 3, 2022

thanks @uschmidt83 for raising this issue in bioimage-io/core-bioimage-io-python#260

@github-actions github-actions bot added enhancement New feature or request testing Testing labels May 3, 2022
@FynnBe FynnBe changed the title add test_serialize_with_link_in_path resolve symlinks when tranforming absolute to relative paths during serialization May 3, 2022
@FynnBe FynnBe requested a review from constantinpape May 3, 2022 08:53
@FynnBe FynnBe changed the title resolve symlinks when tranforming absolute to relative paths during serialization resolve symlinks when transforming absolute to relative paths during serialization May 3, 2022
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 3, 2022
Copy link
Collaborator

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FynnBe FynnBe merged commit fa68d18 into main May 3, 2022
@FynnBe FynnBe deleted the resolve_root branch May 3, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request testing Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants