Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/remove-dask-upper-bound #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

evamaxfield
Copy link

Link to Relevant Issue

This pull request resolves #14

Description of Changes

The issue isn't that numpy has an error its that dask is bounded. At least, bioio tests complete just fine using the latest version.

I don't have access to the test files anymore so opening this PR to have tests run things for me.

Only other change is I added uv to the CI job to make installing dependencies much much much faster.

@evamaxfield
Copy link
Author

Seems like all of the tests are passing except for the other bug: #10

Happy to remove the uv stuff if you want. For some reason I thought these were heavier dependencies -- normal pip seems to have ~20 second dependency install vs ~10 second installs with uvso just let me know but seems like we just had a bad upper bound on dask

Copy link
Contributor

@BrianWhitneyAI BrianWhitneyAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally with Dask 2024.6.2 and numpy 2.0.0 and everything passed.

Copy link
Contributor

@SeanLeRoy SeanLeRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants