Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] fix -Wtautological-constant-out-of-range-compare on AIX/xlclang #44

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

mbs-c
Copy link
Contributor

@mbs-c mbs-c commented Oct 21, 2021

Small fix for a warning in base64_valid the clang-based AIX compiler.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #44 (24c3f38) into master (9937e6d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          49       49           
  Lines        8217     8217           
=======================================
  Hits         8051     8051           
  Misses        166      166           
Impacted Files Coverage Δ
src/c4/base64.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9937e6d...24c3f38. Read the comment docs.

@mbs-c
Copy link
Contributor Author

mbs-c commented Oct 21, 2021

On AIX, char is unsigned by default, which is probably why clang wants the explicit cast. Compiling on another platform with -funsigned-char would probably yield the same warning.

@biojppm
Copy link
Owner

biojppm commented Oct 22, 2021

Thanks!

@biojppm biojppm merged commit a6c977b into biojppm:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants