Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message 'closing ] not found' does not use _c4err macro #406

Closed
WhiteAbeLincoln opened this issue Mar 6, 2024 · 0 comments · Fixed by #407
Closed

Error message 'closing ] not found' does not use _c4err macro #406

WhiteAbeLincoln opened this issue Mar 6, 2024 · 0 comments · Fixed by #407

Comments

@WhiteAbeLincoln
Copy link
Contributor

All other calls to Parser::_err seem to come from the _c4err macro. I don't think that this is intentional considering it's the only direct invocation that I could find.

Running grep -R -e '\(\s\|\.\|->\)_err(' rapidyaml gives us all occurrances of _err( at a boundary:

rapidyaml/src/c4/yml/parse.cpp:            _err("closing ] not found");
rapidyaml/src/c4/yml/parse.hpp:    template<class ...Args> void _err(csubstr fmt, Args const& C4_RESTRICT ...args) const;
rapidyaml/src/c4/yml/detail/parser_dbg.hpp:         this->_err("ERROR:\n" "{}:{}: " fmt, __FILE__, __LINE__, ## __VA_ARGS__); } while(0)
rapidyaml/src/c4/yml/detail/parser_dbg.hpp:         this->_err("ERROR: " fmt, ## __VA_ARGS__); } while(0)

The first is this error message, the second is the definition of the Parser::_err method, and the third & fourth are the call within the _c4err macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant