Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add swig as build dependency #395

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

mboutet
Copy link
Contributor

@mboutet mboutet commented Nov 13, 2023

@mboutet mboutet changed the title chore: Add swig as build dependency fix: Add swig as build dependency Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #395 (9fffec0) into master (a5eefff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #395   +/-   ##
=======================================
  Coverage   96.59%   96.59%           
=======================================
  Files          22       22           
  Lines        8155     8155           
=======================================
  Hits         7877     7877           
  Misses        278      278           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mboutet
Copy link
Contributor Author

mboutet commented Nov 13, 2023

I tested installing rapidyaml from my GitHub fork and this fixes the issue with installing rapidyaml. I'm using poetry and this is what I did:

# ... truncated

[build-system]
requires = ["poetry-core", "swig"]
build-backend = "poetry.core.masonry.api"

# ... truncated

[tool.poetry.dependencies]

# rapidyaml = { git = "https://github.com/biojppm/rapidyaml.git", rev = "a5eefff1f87de8f1ec85cea34bed361d40868631" }
rapidyaml = { git = "https://github.com/mboutet/rapidyaml.git", rev = "9fffec0876e571784e2d98b1c75c0639a8381806" }

# ... truncated

@mboutet mboutet marked this pull request as ready for review November 13, 2023 15:41
@biojppm biojppm merged commit 8c1d622 into biojppm:master Nov 14, 2023
165 of 172 checks passed
@biojppm
Copy link
Owner

biojppm commented Nov 14, 2023

Thanks!

@mboutet mboutet deleted the patch-3 branch November 14, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants