Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #9

Merged
merged 12 commits into from
Mar 31, 2019
Merged

Dev #9

merged 12 commits into from
Mar 31, 2019

Conversation

biojppm
Copy link
Owner

@biojppm biojppm commented Mar 31, 2019

No description provided.

@codecov
Copy link

codecov bot commented Mar 31, 2019

Codecov Report

Merging #9 into master will increase coverage by 2.01%.
The diff coverage is 95.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #9      +/-   ##
==========================================
+ Coverage   88.52%   90.53%   +2.01%     
==========================================
  Files          52       53       +1     
  Lines        4349     4734     +385     
==========================================
+ Hits         3850     4286     +436     
+ Misses        499      448      -51
Impacted Files Coverage Δ
test/generic_map.cpp 100% <ø> (ø) ⬆️
test/test_group.cpp 98.13% <ø> (+3.96%) ⬆️
test/tag_property.cpp 100% <ø> (ø) ⬆️
test/simple_doc.cpp 100% <ø> (ø) ⬆️
src/c4/yml/parse.hpp 100% <ø> (ø) ⬆️
src/c4/yml/detail/checks.hpp 100% <100%> (ø) ⬆️
test/test_case.hpp 83.87% <100%> (+0.53%) ⬆️
test/simple_set.cpp 100% <100%> (ø)
test/basic.cpp 99.72% <100%> (+0.06%) ⬆️
src/c4/yml/tree.hpp 95.37% <80%> (+0.09%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f468490...0d1b227. Read the comment docs.

@coveralls
Copy link

coveralls commented Mar 31, 2019

Pull Request Test Coverage Report for Build 204

  • 238 of 257 (92.61%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+2.3%) to 89.488%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/c4/yml/tree.hpp 4 5 80.0%
src/c4/yml/parse.cpp 69 72 95.83%
src/c4/yml/emit.def.hpp 24 29 82.76%
src/c4/yml/tree.cpp 140 150 93.33%
Files with Coverage Reduction New Missed Lines %
src/c4/yml/parse.cpp 1 86.2%
Totals Coverage Status
Change from base Build 195: 2.3%
Covered Lines: 2920
Relevant Lines: 3263

💛 - Coveralls

@biojppm biojppm merged commit ad9fa5e into master Mar 31, 2019
biojppm added a commit that referenced this pull request Jun 9, 2019
-tree: add set_key()/set_val()
-tree: add lookup_path()
-fixes to emit()
-fix docs
-fix sets
-fix parse problem with seqs nested in maps
-add tests to increase coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants