Fix the error from shell being printed on the standard error. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to resolve the following: sh: 1: domainjoin-cli: not found During the first pass of the `pbis-open::default` recipe. Also, move to the `shell_out` and coerce `domain_member` into a boolean. Signed-off-by: Krzysztof Wilczynski <krzysztof.wilczynski@linux.com>
|
Note: this is just a tiny improvement over the original implementation. Better way would be to re-factor and factor-out some of these to a helper, etc. |
jking916
added a commit
that referenced
this pull request
Aug 31, 2015
Fix the error from shell being printed on the standard error.
|
Thanks for the improvements. No idea how all of that whitespace got in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to resolve the following:
sh: 1: domainjoin-cli: not foundDuring the first pass of the
pbis-open::defaultrecipe. Also, move tothe
shell_outand coercedomain_memberinto a boolean.Signed-off-by: Krzysztof Wilczynski krzysztof.wilczynski@linux.com