[ENH] Remove use of pkg_resources #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
==========================================
+ Coverage 75.57% 76.47% +0.90%
==========================================
Files 99 99
Lines 21047 21031 -16
==========================================
+ Hits 15906 16084 +178
+ Misses 5141 4947 -194 ☔ View full report in Codecov by Sentry. |
ales-erjavec
force-pushed
the
remove-pkg-resources
branch
3 times, most recently
from
bc53001
to
0799ee5
Compare
3 tasks
ales-erjavec
force-pushed
the
remove-pkg-resources
branch
2 times, most recently
from
f7c2ab1
to
97c6829
Compare
ales-erjavec
force-pushed
the
remove-pkg-resources
branch
from
97c6829
to
e9f8fe8
Compare
Also remove some unused functions.
Also increase coverage for config tests
ales-erjavec
force-pushed
the
remove-pkg-resources
branch
from
e9f8fe8
to
f325663
Compare
ales-erjavec
force-pushed
the
remove-pkg-resources
branch
from
f325663
to
3bf8b05
Compare
3 tasks
Because we break api in discovery with the changing the type of pkg_resources.Distribution with importlib.metadata.Distribution
ales-erjavec
force-pushed
the
remove-pkg-resources
branch
from
3bf8b05
to
8018377
Compare
|
LGTM. It is a lot, so I hope I didn't miss anything. I tested all the functionalities that have been changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
pkg_resources is deprecated.
Changes
Remove/replace use of pkg_resources with importlib.metadata, importlib.resources, pkgutil and packaging.
This also bumps version to 0.2.* because it is backwards incompatible due to differences in exposed types in the discovery process. This should trigger the
orange-canvas-core>=0.1.30,<0.2acondition in https://github.com/biolab/orange3/blob/78f7b30a89a7b78ef6442f0b828f41a6f5c27951/requirements-gui.txt#L1