Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Reconfigure stylesheet on application palette change #291

Merged
merged 1 commit into from Dec 12, 2023

Conversation

ales-erjavec
Copy link
Collaborator

Issue

Fixes biolab/orange3#6653

Changes

Reconfigure stylesheet on application palette change

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cbf2e9a) 75.57% compared to head (76e5981) 75.63%.
Report is 2 commits behind head on master.

Files Patch % Lines
orangecanvas/main.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   75.57%   75.63%   +0.06%     
==========================================
  Files          99       99              
  Lines       21047    21066      +19     
==========================================
+ Hits        15906    15934      +28     
+ Misses       5141     5132       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janezd janezd self-assigned this Dec 8, 2023
@janezd
Copy link
Contributor

janezd commented Dec 8, 2023

I could reproduce the bug - labels indeed disappeared. After this PR, switching to dark mode has no effect - that is, labels remain black (and background remains white). Was this the intention?

@ales-erjavec
Copy link
Collaborator Author

No. It is supposed to change:

Screen Recording 2023-12-08 at 11 41 53 mov

What version of PyQt do you have installed? I am testing with PyQt6 6.5

@janezd
Copy link
Contributor

janezd commented Dec 12, 2023

Note from Slack: Python 3.10 from Conda is linked with macOS SDK 10.9 and does not receive palette change events. As suggested by @ales-erjavec, I tried with 3.11 and it works.

@janezd janezd merged commit c71cf7b into biolab:master Dec 12, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode on Mac: widget names in white text on white background, therefore invisible
3 participants