ListViewFilter: Retain selection when filtering #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #270 +/- ##
==========================================
- Coverage 71.72% 71.49% -0.24%
==========================================
Files 34 34
Lines 9086 9100 +14
==========================================
- Hits 6517 6506 -11
- Misses 2569 2594 +25 ☔ View full report in Codecov by Sentry. |
janezd
reviewed
Apr 12, 2024
orangewidget/utils/listview.py
Outdated
| try: | ||
| yield | ||
| finally: | ||
| signal.connect(slot, connection_type) |
There was a problem hiding this comment.
Perhaps blocking signals (https://doc.qt.io/qt-6/qobject.html#blockSignals) would be better the temporarily disconnecting them?
Also: search the code for def blocked(. You'll find that a similar function already exists in two other places. Perhaps we should introduce one in orange-widget-base and then (after release...) use it wherever needed?
There was a problem hiding this comment.
Or even use an existing one at
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes biolab/orange3#6768
Description of changes
The default selection corresponds to
QSortFilterProxyModel.Apply selection mapped to a source model.
Includes