Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add support for custom gene sets, reference genes and enrichment #67

Merged
merged 5 commits into from Jun 27, 2018

Conversation

JakaKokosar
Copy link
Member

@JakaKokosar JakaKokosar commented Jun 12, 2018

Issue

Fixes #64
Fixes #65

Description of changes

Refactor OWGeneSets and extend this widget to support enrichment analysis.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Jun 12, 2018

Codecov Report

Merging #67 into master will increase coverage by 0.29%.
The diff coverage is 37.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   23.43%   23.73%   +0.29%     
==========================================
  Files          37       37              
  Lines        3303     3333      +30     
==========================================
+ Hits          774      791      +17     
- Misses       2529     2542      +13
Impacted Files Coverage Δ
orangecontrib/bioinformatics/geneset/__init__.py 41.66% <33.33%> (ø) ⬆️
orangecontrib/bioinformatics/geneset/utils.py 78.76% <38.23%> (-17.63%) ⬇️
orangecontrib/bioinformatics/utils/statistics.py 37.14% <0%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19179f9...35b0382. Read the comment docs.

@BlazZupan
Copy link
Contributor

I am getting a strange list of categories when using the data from Dictyostelium (see the image, and entries 5', 5, 3, and "contractile ring contraction" under GO).

screen shot 2018-06-20 at 14 42 00

@BlazZupan
Copy link
Contributor

The minimum count filter can go together with the other two filter fields. Put it first, before p-value, and call it "Count". The default is checked, with a minimal count set to 5.

Some minor corrections:

  • Maximum False discovery rate -> Maximum false discovery rate (in mouse-over text)
  • Maximum p-value -> Maximum p-value of the enrichment score (in mouse-over text)
  • Gene Set Databases - > Gene Set Categories
  • In the hierarchy under Gene Sets Databases, remove the table header "Category"

@BlazZupan
Copy link
Contributor

This widget can be called Gene Set Enrichment. It can replace Gene Sets widget (remove the widget, but use its icon). The current icon for Set Enrichment is an old one and can be removed.

@BlazZupan BlazZupan merged commit a4451bc into biolab:master Jun 27, 2018
@JakaKokosar JakaKokosar deleted the genesets_enrichement branch June 21, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants