[FIX] Context attributes with metas in Sieve and Mosaic #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.27% (diff: 100%)@@ master #1545 diff @@
==========================================
Files 77 77
Lines 7624 7624
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6730 6730
Misses 894 894
Partials 0 0
|
|
What about setting the default value in ContextSetting to also include meta values? |
|
What is the problem with settings in Mosaic? If I modify settings and switch between two datasets, the modified settings are restored for each dataset. What do I need to do to replicate the problem? |
You're the context expert. If it doesn't break anything, let's change the default. Will you do it and close this PR? This PR also fixes a smaller glitch: the default value for the selection should be
I can no longer replicate it either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a similar problem as #1538, but for Sieve and Mosaic.
The fix for Mosaic has no effect since context settings in Mosaic do not work. @astaric, can you check why?
We can modify Mosaic to use models (like Sieve), which would make the problem go away, but we still need to fix the bug in settings (if there is one).