Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWPCA: Fix crash for dataset with no rows or no attributes #1915

Merged
merged 1 commit into from Jan 13, 2017

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Jan 12, 2017

Issue

Fixes #1913

Description of changes

To reproduce:

  • No attributes: File (Iris) -> move all attributes to metas -> PCA
  • No rows: File (Iris) -> SelectRows (condition that results in 0 rows) -> PCA
Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT added this to the 3.3.10 milestone Jan 12, 2017
@codecov-io
Copy link

codecov-io commented Jan 12, 2017

Current coverage is 89.28% (diff: 100%)

Merging #1915 into master will not change coverage

@@             master      #1915   diff @@
==========================================
  Files            86         86          
  Lines          9109       9109          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           8133       8133          
  Misses          976        976          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 3e6e181...a10cef4

@astaric astaric merged commit bdf8f2c into biolab:master Jan 13, 2017
astaric added a commit to astaric/orange3 that referenced this pull request Jan 13, 2017
[FIX] OWPCA: Fix crash for dataset with no rows or no attributes
(cherry picked from commit bdf8f2c)
astaric added a commit to astaric/orange3 that referenced this pull request Jan 18, 2017
[FIX] OWPCA: Fix crash for dataset with no rows or no attributes
(cherry picked from commit bdf8f2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants