[FIX] Schema-only settings in components #2613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema-only settings within components were not removed in SettingsHandler.update_defaults
astaric
changed the title
astaric
approved these changes
Sep 22, 2017
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
+ Coverage 74.99% 74.99% +<.01%
==========================================
Files 331 331
Lines 58069 58076 +7
==========================================
+ Hits 43548 43555 +7
Misses 14521 14521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Schema-only settings within components were not removed in SettingsHandler.update_defaults
Includes