Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX][ENH] Scatter Plot VizRank: some fixes and regard to color #2787

Merged
merged 2 commits into from Nov 27, 2017
Merged

[FIX][ENH] Scatter Plot VizRank: some fixes and regard to color #2787

merged 2 commits into from Nov 27, 2017

Conversation

jerneju
Copy link
Contributor

@jerneju jerneju commented Nov 21, 2017

Issue

Fixes #2037

  1. Scatter Plot VizRank uses jittered data which is wrong.
  2. Uses custom code for calculating combinations.
  3. Uses indices.
  4. Informative projections are ranked based on the class variable.
Description of changes
  1. Scaled data instead of jittered data.
    2) Uses combinations from itertools.
    3) Now it uses variables instead of indices.
  2. Informative projections are ranked based on the selected color variable.

Also added one test to increase coverage (test method row_for_state). Sadly code coverage is not measured when running a code in a thread and that is why test calls this specific method.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Nov 21, 2017

Codecov Report

Merging #2787 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #2787      +/-   ##
=========================================
+ Coverage    76.1%   76.1%   +<.01%     
=========================================
  Files         338     338              
  Lines       59760   59767       +7     
=========================================
+ Hits        45479   45486       +7     
  Misses      14281   14281

@jerneju jerneju added this to the 3.8 milestone Nov 22, 2017
@jerneju jerneju changed the title [WIP][FIX][ENH] Scatter Plot VizRank: some fixes and regard to color [FIX][ENH] Scatter Plot VizRank: some fixes and regard to color Nov 22, 2017
@lanzagar lanzagar merged commit 61ba36c into biolab:master Nov 27, 2017
@jerneju jerneju deleted the scatterplot-vizrank branch November 27, 2017 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants