Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canvas: Remove CommonMark dependency and markdown support #3234

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

ales-erjavec
Copy link
Contributor

Issue

CommonMark release 0.8.0 breaks on case insensitive file systems (readthedocs/commonmark.py#134)

Description of changes
  • Remove CommonMark dependency and markdown support
Includes
  • Code changes
  • Tests
  • Documentation

@astaric astaric merged commit 9b1fdc3 into biolab:master Sep 7, 2018
@ales-erjavec ales-erjavec deleted the fixes/remove-commonmark branch September 10, 2018 07:09
@milianj
Copy link

milianj commented Sep 11, 2018

Is it broken on Windows (Win7x64) too or is this a whole different problem. I'm trying to run Orange. Any feedback is appreciated.

C:\Dev\WPy-3702\scripts>python -m Orange.canvas
Traceback (most recent call last):
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\runpy.py", line 193, in run_module_as_main
"main", mod_spec)
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\runpy.py", line 85, in run_code
exec(code, run_globals)
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas_main
.py", line 30, in
from Orange.canvas.application.canvasmain import CanvasMainWindow
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas\application\canvasmain.py", line 61, in
from .canvastooldock import CanvasToolDock, QuickCategoryToolbar,
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas\application\canvastooldock.py", line 25, in
from ..document.quickmenu import MenuPage
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas\document_init
.py", line 17, in
from .schemeedit import SchemeEditWidget
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas\document\schemeedit.py", line 37, in
from .suggestions import Suggestions
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas\document\suggestions.py", line 7, in
from .interactions import NewLinkAction
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas\document\interactions.py", line 28, in
from ..canvas import items
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas\canvas\items_init_.py", line 9, in
from .annotationitem import TextAnnotation, ArrowAnnotation
File "C:\Dev\WPy-3702\python-3.7.0.amd64\lib\site-packages\Orange\canvas\canvas\items\annotationitem.py", line 7, in
import CommonMark
ModuleNotFoundError: No module named 'CommonMark'

@samperd
Copy link

samperd commented Sep 12, 2018

I ran into this problem when upgrading from orange 3.11 to 3.15 within anaconda on ubuntu linux 16.04

  • upgrade conda packages through conda terminal
  • installed orange canvas through anaconda navigator gui
  • orange would not load
  • went to anaconda-navigator environments
  • selected installed packages and search for 'CommonMark'
  • downgraded from 0.8 to 0.7.5
  • started orange and it worked.

Look forward to patch working its way through the packaging system.

Cheers

@leeherman99
Copy link

This issue exist in both Win7 and Win10.

Installing recommonmark works, but this downgrades your Orange to 3.4.4. I would have liked samperd's solution, but downgrading the commonmark package in the Navigator environments tool doesn't seem to work for me. Getting:

ImportError: numpy.core.multiarray failed to import
ImportError: numpy.core.multiarray failed to import
ImportError: numpy.core.multiarray failed to import
ImportError: numpy.core.multiarray failed to import
Traceback (most recent call last):
File "C:\ProgramData\Anaconda3\Scripts\orange-canvas-script.py", line 6, in
from Orange.canvas.main import main
File "C:\ProgramData\Anaconda3\lib\site-packages\Orange_init_.py", line 1, in
from .misc.lazy_module import LazyModule
File "C:\ProgramData\Anaconda3\lib\site-packages\Orange\misc_init
.py", line 3, in
from .distmatrix import DistMatrix
File "C:\ProgramData\Anaconda3\lib\site-packages\Orange\misc\distmatrix.py", line 3, in
from Orange.data import Table, StringVariable, Domain
File "C:\ProgramData\Anaconda3\lib\site-packages\Orange\data_init_.py", line 4, in
from .variable import *
File "C:\ProgramData\Anaconda3\lib\site-packages\Orange\data\variable.py", line 12, in
from Orange.util import Registry, color_to_hex, hex_to_color, Reprable
File "C:\ProgramData\Anaconda3\lib\site-packages\Orange\util.py", line 17, in
from Orange.data.util import scale # pylint: disable=unused-import
File "C:\ProgramData\Anaconda3\lib\site-packages\Orange\data\util.py", line 6, in
from scipy import sparse as sp
File "C:\ProgramData\Anaconda3\lib\site-packages\scipy_init_.py", line 62, in
from numpy import show_config as show_numpy_config
ImportError: cannot import name 'show_config'

@ajdapretnar
Copy link
Contributor

@leeherman99 Perhaps you didn't set the conda-forge channel? conda config --add channels conda-forge

@leeherman99
Copy link

No, actually I did.

The solution was to upgrade to version 3.16. It works great now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants