New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__main__: Update Orange in-app #5064
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5064 +/- ##
==========================================
+ Coverage 84.73% 84.76% +0.02%
==========================================
Files 286 286
Lines 60042 60100 +58
==========================================
+ Hits 50879 50944 +65
+ Misses 9163 9156 -7 |
dbe3bdf
to
a71c2af
Compare
This needs to be tested with Anaconda Navigator, making sure it doesn't break anything by breaking dependencies. |
I think this is a great addition. In the same time might be confusing to users. What happens if they update the orange3 toolbox from inside Orange and then get a message to update Orange (that would involve orange-canvas-core and orange-widget-base)? Could there be a general solution to update all sub-packages from within Orange to be more user friendly (also not needing to uninstall/reinstall Orange on Windows for example)? |
I don't quite understand. If Orange is updated, so are orange-widget-base and orange-canvas-core. Is this related to the bug you described in #5078?
How would you envision such a solution? Would an 'Upgrade All' button on the Add-ons installer dialogue, which would be equivalent to clicking on the checkboxes of all installed Add-ons, suffice? |
Before merging this PR we need to test at least the following scenarios.
The last test will likely fail. |
I didn't try all combinations but it's not looking good. |
(note, all of this is already possible in the released version, this PR just directs people to it via a notif) |
I have tried updating Orange in-app on lab Win machines. Try are at 3.23.1. Installing failed both with regular run and run as admin. Error log below:
|
Note: @markotoplak and @PrimozGodec say that this can only be done after we prevent mixing add-ons from conda and pip. We discussed that it seems that Orange can now stop downloading add-ons from Conda and use only pip. |
Here is a user that had problems with updating through the add-on dialog #5693. |
Closing for now because it needs work on add-on infrastructure. Continue discussion on biolab/orange-canvas-core#213. |
Issue
As Orange can be updated from the Add-ons dialogue, there seems to be no need to redownload the whole package.
Description of changes
On clicking 'Yes' in the update request notification, the Installer (previously Add-ons) dialogue will open, and select Orange3 to be updated. All the user must do is press Ok.
If the user does not have install permissions, the website is opened to prompt a download.
Includes