Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Test with Python 3.12 #6729

Merged
merged 4 commits into from Mar 15, 2024
Merged

Conversation

PrimozGodec
Copy link
Contributor

@PrimozGodec PrimozGodec commented Feb 9, 2024

Description of changes
  • Test Orange on Python 3.12, which has been out for some time now.
  • Replace distutils, which was deprecated and removed in Python 3.12 form tests.
  • Replace wrongly used called_with (should be assert_called_with) in test_owpredictions. Since it was not even a valid check (selection model change when the model is set to None in the widget), I replaced it with just assert_called_once, which checks that unregister was called.
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec
Copy link
Contributor Author

I think the issue should be solved when Catboost provides Python 3.12 wheels. I asked them if they could provide them.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Merging #6729 (e03201c) into master (f970414) will increase coverage by 0.00%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6729   +/-   ##
=======================================
  Coverage   88.15%   88.15%           
=======================================
  Files         323      323           
  Lines       70749    70748    -1     
=======================================
+ Hits        62369    62371    +2     
+ Misses       8380     8377    -3     

@PrimozGodec
Copy link
Contributor Author

Waiting for pavlin-policar/openTSNE#255

@PrimozGodec PrimozGodec reopened this Mar 13, 2024
@PrimozGodec PrimozGodec marked this pull request as ready for review March 13, 2024 18:43
@@ -147,7 +147,7 @@ jobs:
name: PyQt6

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this downgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking. It probably remained the same from the previous version of PR. Fixed now.

@ales-erjavec ales-erjavec merged commit cd45d48 into biolab:master Mar 15, 2024
28 of 30 checks passed
@PrimozGodec PrimozGodec deleted the test-python312 branch March 15, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants