Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

change owlgen to use default_prefix for namespace #180

Merged
merged 12 commits into from
Jul 10, 2020
Merged

Conversation

cmungall
Copy link
Contributor

@cmungall cmungall commented Jul 5, 2020

Fixes bug where owlgen placed all classes, properties into meta namespace.
The fix incvolves changing how definition_uri is populated while schema loading.
Fixes #163


…pace.

The fix incvolves changing how definition_uri is populated while schema loading.
Fixes #163

Replaces #164
@hsolbrig
Copy link
Member

hsolbrig commented Jul 7, 2020

A couple of questions / problems with this fix:

  1. The separator between the base URI and item has been changed from '/' to '#'. This breaks some existing code -- we need to discuss why and whether there might be a gentler way to do it.
  2. There is a problem with aliases in the owl generator. See: tests/test_issues/input/issue_163c.yaml for details. We need to discuss approaches

@cmungall
Copy link
Contributor Author

cmungall commented Jul 8, 2020

hmm I don't recall intending to change anything from / to #...

hsolbrig added a commit that referenced this pull request Jul 8, 2020
@hsolbrig
Copy link
Member

hsolbrig commented Jul 8, 2020

@cmungall
Copy link
Contributor Author

cmungall commented Jul 9, 2020

OK, changed '#' to '/' (this is only the case where a prefix is not declared)

Looks like I now have conflicts, most of these seem to be generated test files, maybe I shouldn't have included in the PR

@hsolbrig
Copy link
Member

We'll catch the conflicts -- @jiaola is going to create a merge action that automatically rewrites them. Thanks!

Added default_range to yaml files to reduce testing noise.
Changed assert statements in test to self.assertIn (asserts can get optimized out...)
@hsolbrig hsolbrig merged commit f662f6d into master Jul 10, 2020
@hsolbrig hsolbrig deleted the issue-163-redux branch July 10, 2020 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

owlgen uses namespaces incorrectly
2 participants