This repository has been archived by the owner on Oct 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
change owlgen to use default_prefix for namespace #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A couple of questions / problems with this fix:
|
hmm I don't recall intending to change anything from / to #... |
hsolbrig
added a commit
that referenced
this pull request
Jul 8, 2020
OK, changed '#' to '/' (this is only the case where a prefix is not declared) Looks like I now have conflicts, most of these seem to be generated test files, maybe I shouldn't have included in the PR |
We'll catch the conflicts -- @jiaola is going to create a merge action that automatically rewrites them. Thanks! |
Added default_range to yaml files to reduce testing noise. Changed assert statements in test to self.assertIn (asserts can get optimized out...)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug where owlgen placed all classes, properties into meta namespace.
The fix incvolves changing how definition_uri is populated while schema loading.
Fixes #163