-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip dependency conflict? #371
Comments
Resolves #371? Untested for impact on kgx
Resolves #371? Untested for impact on kgx
I saw this in KG-IDG and KG-COVID-19 - the fix was to pin |
Hi @caufieldjh, to my knowledge, changing the click dependency to I'd be hesitant to pin black to a specific release, unless strictly necessary (@cmungall may corroborate this...) I just checked: linkml release v1.1.18 has the patch. KGX only pulls in LinkML 'latest' (no release constraints). Maybe you simply need to refresh your linkml dependency? |
Upgrading to the most recent KGX (and having it use the new linkml release) fixes this in the KG projects. Thanks! |
KGX pulls in black with (
click>=8.0.0)
but also setsClick~=7.0
.To permit
black
to get 8.0.0, we set kgx also rather use click>=7.0.0 ?See also issue linkml/linkml#592 and PR linkml/linkml#593.
This PR is using the patched PR 593 version of linkml in its requirements.txt. This workaround should be removed and the dependency reverted to the regular (latest) linkml release, once linkml itself is patched?
These changes (both in kgx and linkml) appear to clear the unit tests - no errors - so this click version >=7.0.0 (not pinned ~= 7.0.0?) does not seem to be a problem.
The text was updated successfully, but these errors were encountered: