Merge pull request #642 from biolink/go-site-2038-gorule-0000002-no-n…

…ot-to-protein-binding For #2038 Changed to error from warning
biolink · Aug 26, 2023 · 6218621 · 6218621
2 parents 95a02f9 + 44aa4a2
commit 6218621
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ontobio/io/qc.py b/ontobio/io/qc.py
@@ -178,7 +178,7 @@ def repair(self, annotation: association.GoAssociation, group=None) -> Tuple[Lis
 class GoRule02(GoRule):
 
     def __init__(self):
-        super().__init__("GORULE:0000002", "No 'NOT' annotations to 'protein binding ; GO:0005515'", FailMode.SOFT)
+        super().__init__("GORULE:0000002", "No 'NOT' annotations to 'protein binding ; GO:0005515'", FailMode.HARD)
 
     def test(self, annotation: association.GoAssociation, config: assocparser.AssocParserConfig, group=None) -> TestResult:
 

diff --git a/tests/test_qc.py b/tests/test_qc.py
@@ -79,7 +79,7 @@ def test_go_rule02():
     assoc = make_annotation(qualifier="NOT", goid="GO:0005515").associations[0]
 
     test_result = qc.GoRule02().test(assoc, all_rules_config())
-    assert test_result.result_type == qc.ResultType.WARNING
+    assert test_result.result_type == qc.ResultType.ERROR
 
     assoc.negated = False
     test_result = qc.GoRule02().test(assoc, all_rules_config())